fix the cursor height on a new empty line #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coerce its height AtMost to the font ascent (only for newEmptyLine). If it's not new empty line, we keep the original cursor height
...ose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/platform/SkiaParagraph.skiko.kt
Outdated
Show resolved
Hide resolved
dima-avdeev-jb
approved these changes
Aug 24, 2022
igordmn
approved these changes
Aug 24, 2022
Co-authored-by: dima.avdeev <99798741+dima-avdeev-jb@users.noreply.github.com>
eymar
added a commit
that referenced
this pull request
Oct 26, 2022
* fix the cursor height on a new empty line coerce its height AtMost to the font ascent (only for newEmptyLine). If it's not new empty line, we keep the original cursor height
eymar
added a commit
that referenced
this pull request
Nov 16, 2022
* fix the cursor height on a new empty line coerce its height AtMost to the font ascent (only for newEmptyLine). If it's not new empty line, we keep the original cursor height
eymar
added a commit
that referenced
this pull request
Jan 13, 2023
* fix the cursor height on a new empty line coerce its height AtMost to the font ascent (only for newEmptyLine). If it's not new empty line, we keep the original cursor height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JetBrains/compose-multiplatform#1895