Make ScrollbarAdapter for LazyList take contentPadding into account. #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
reviewed
Jan 9, 2023
...oundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/Scrollbar.desktop.kt
Show resolved
Hide resolved
igordmn
approved these changes
Jan 10, 2023
m-sasha
deleted the
bugfix/compose-jb-2604-scroll-lazycolumn-with-content-padding
branch
eymar
pushed a commit
that referenced
this pull request
Jan 13, 2023
This was referenced Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
LazyScrollbarAdapter. maxScrollOffsetshould take into account the content padding.Testing
Test: with a manual reproducer and an automated test
Issues Fixed
Fixes: JetBrains/compose-multiplatform#2604
Before fix:
before.mp4
After fix:
after.mp4