Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't depend on kotlinx-coroutines-swing #1943

Closed
igordmn opened this issue Mar 9, 2022 · 2 comments · Fixed by JetBrains/skiko#515
Closed

Don't depend on kotlinx-coroutines-swing #1943

igordmn opened this issue Mar 9, 2022 · 2 comments · Fixed by JetBrains/skiko#515
Assignees
@igordmn
Labels
bug Something isn't working desktop wait for build

Comments

@igordmn
Copy link
Collaborator

igordmn commented Mar 9, 2022 •
edited
Loading

Compose 1.1.0

We need to use Swing dispatcher inside Compose, but when we depend on kotlinx-coroutines-swing library, we override Dispatchers.Main. This can lead to undefined behaviour, if application requires a different Dispatchers.Main. For example, see https://youtrack.jetbrains.com/issue/IDEA-285839

The solution:

  • copy Dispathcer.Swing to skiko library, use this copied dispatcher inside Compose
  • remove kotlinx-coroutines-swing from skiko and Compose dependencies
@igordmn igordmn added bug Something isn't working desktop labels Mar 9, 2022
@igordmn igordmn self-assigned this Mar 9, 2022
igordmn added a commit to JetBrains/skiko that referenced this issue Mar 9, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing
b1eda25 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943 on skiko side
igordmn added a commit to JetBrains/skiko that referenced this issue Mar 9, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing
a56ed2e 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943 on skiko side
igordmn added a commit to JetBrains/skiko that referenced this issue Mar 9, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing
6370fa2 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943 on skiko side
@igordmn igordmn mentioned this issue Mar 9, 2022
Merged
igordmn added a commit to JetBrains/skiko that referenced this issue Mar 9, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing (#515)
617eae5 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943 on skiko side
@igordmn igordmn reopened this Mar 9, 2022
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Mar 10, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing
b19e55d 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943

RelNote:
Compose don't depend on `kotlinx-coroutines-swing` now. So if you use `Dispatchers.Swing` or `Dispatchers.Main` in your code, add this dependency into `build.gradle.kts`:
```
dependencies {
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
}
```
@igordmn igordmn mentioned this issue Mar 10, 2022
Merged
@igordmn
Copy link
Collaborator Author

igordmn commented Mar 13, 2022

Should be fixed in 1.1.1

@igordmn igordmn closed this as completed Mar 13, 2022
@igordmn igordmn mentioned this issue Mar 13, 2022
Closed
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Mar 28, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing
a487d53 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943

RelNote:
Compose don't depend on `kotlinx-coroutines-swing` now. So if you use `Dispatchers.Swing` or `Dispatchers.Main` in your code, add this dependency into `build.gradle.kts`:
```
dependencies {
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
}
```

# Conflicts:
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/TestComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/TestUtils.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowTest.kt
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Mar 30, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing
6488dba 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943

RelNote:
Compose don't depend on `kotlinx-coroutines-swing` now. So if you use `Dispatchers.Swing` or `Dispatchers.Main` in your code, add this dependency into `build.gradle.kts`:
```
dependencies {
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
}
```

# Conflicts:
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/TestComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/TestUtils.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowTest.kt
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Apr 4, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing
54c448c 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943

RelNote:
Compose don't depend on `kotlinx-coroutines-swing` now. So if you use `Dispatchers.Swing` or `Dispatchers.Main` in your code, add this dependency into `build.gradle.kts`:
```
dependencies {
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
}
```

# Conflicts:
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/TestComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/TestUtils.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowTest.kt
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Apr 4, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing
1097dd0 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943

RelNote:
Compose don't depend on `kotlinx-coroutines-swing` now. So if you use `Dispatchers.Swing` or `Dispatchers.Main` in your code, add this dependency into `build.gradle.kts`:
```
dependencies {
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
}
```

# Conflicts:
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/TestComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/TestUtils.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowTest.kt
eymar pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Apr 18, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing
23633cf 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943

RelNote:
Compose don't depend on `kotlinx-coroutines-swing` now. So if you use `Dispatchers.Swing` or `Dispatchers.Main` in your code, add this dependency into `build.gradle.kts`:
```
dependencies {
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
}
```

# Conflicts:
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/TestComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/TestUtils.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowTest.kt
manu-unter pushed a commit to manu-unter/skiko that referenced this issue May 16, 2022
@igordmn @manu-unter
Don't depend on kotlinx-coroutines-swing (JetBrains#515)
8969acd 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943 on skiko side
eymar pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Jun 2, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing
dc86a59 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943

RelNote:
Compose don't depend on `kotlinx-coroutines-swing` now. So if you use `Dispatchers.Swing` or `Dispatchers.Main` in your code, add this dependency into `build.gradle.kts`:
```
dependencies {
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
}
```

# Conflicts:
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/TestComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/TestUtils.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowTest.kt
eymar pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Jun 27, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing
5395550 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943

RelNote:
Compose don't depend on `kotlinx-coroutines-swing` now. So if you use `Dispatchers.Swing` or `Dispatchers.Main` in your code, add this dependency into `build.gradle.kts`:
```
dependencies {
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
}
```

Change-Id: Iefec704aceb25d03c460a227b3aa0921996f14ed

# Conflicts:
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/TestComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/TestUtils.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowTest.kt
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Aug 18, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing
ae62d65 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943

RelNote:
Compose don't depend on `kotlinx-coroutines-swing` now. So if you use `Dispatchers.Swing` or `Dispatchers.Main` in your code, add this dependency into `build.gradle.kts`:
```
dependencies {
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
}
```

Change-Id: Iefec704aceb25d03c460a227b3aa0921996f14ed

# Conflicts:
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/TestComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/TestUtils.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowTest.kt
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Aug 18, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing
89bcba8 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943

RelNote:
Compose don't depend on `kotlinx-coroutines-swing` now. So if you use `Dispatchers.Swing` or `Dispatchers.Main` in your code, add this dependency into `build.gradle.kts`:
```
dependencies {
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
}
```

Change-Id: Iefec704aceb25d03c460a227b3aa0921996f14ed

# Conflicts:
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/TestComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/TestUtils.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowTest.kt
eymar pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Oct 26, 2022
@igordmn
Don't depend on kotlinx-coroutines-swing
ca88116 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943

RelNote:
Compose don't depend on `kotlinx-coroutines-swing` now. So if you use `Dispatchers.Swing` or `Dispatchers.Main` in your code, add this dependency into `build.gradle.kts`:
```
dependencies {
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
}
```

Change-Id: Iefec704aceb25d03c460a227b3aa0921996f14ed

# Conflicts:
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/TestComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/TestUtils.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowTest.kt
eymar pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Nov 16, 2022
@igordmn @eymar
Don't depend on kotlinx-coroutines-swing
9a87822 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943

RelNote:
Compose don't depend on `kotlinx-coroutines-swing` now. So if you use `Dispatchers.Swing` or `Dispatchers.Main` in your code, add this dependency into `build.gradle.kts`:
```
dependencies {
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
}
```

Change-Id: Iefec704aceb25d03c460a227b3aa0921996f14ed

# Conflicts:
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/TestComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/TestUtils.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowTest.kt
eymar pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Jan 13, 2023
@igordmn @eymar
Don't depend on kotlinx-coroutines-swing
583540f 
Because it overrides Dispatchers.Main

Fixes JetBrains/compose-multiplatform#1943

RelNote:
Compose don't depend on `kotlinx-coroutines-swing` now. So if you use `Dispatchers.Swing` or `Dispatchers.Main` in your code, add this dependency into `build.gradle.kts`:
```
dependencies {
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
}
```

Change-Id: Iefec704aceb25d03c460a227b3aa0921996f14ed

# Conflicts:
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/TestComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/TestUtils.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowTest.kt
MatkovIvan pushed a commit to MatkovIvan/compose-multiplatform that referenced this issue May 10, 2023
@igordmn @eymar
Don't depend on kotlinx-coroutines-swing
6c81d67 
Because it overrides Dispatchers.Main

Fixes JetBrains#1943

RelNote:
Compose don't depend on `kotlinx-coroutines-swing` now. So if you use `Dispatchers.Swing` or `Dispatchers.Main` in your code, add this dependency into `build.gradle.kts`:
```
dependencies {
    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-swing:$coroutinesVersion")
}
```

Change-Id: Iefec704aceb25d03c460a227b3aa0921996f14ed

# Conflicts:
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/ComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/platform/TestComposeWindowTest.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/TestUtils.kt
#	compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/window/window/WindowTest.kt
@lsrom lsrom mentioned this issue Jun 9, 2024
Closed
@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

@JetBrains JetBrains locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@igordmn igordmn

Labels
bug Something isn't working desktop wait for build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't depend on kotlinx-coroutines-swing JetBrains/skiko
2 participants
@igordmn @okushnikov