Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popups/ExposedDropDown is covered by Keyboard on iOS #4011

Closed
chrisjenx opened this issue Dec 7, 2023 · 7 comments
Closed

Popups/ExposedDropDown is covered by Keyboard on iOS #4011

chrisjenx opened this issue Dec 7, 2023 · 7 comments
Assignees
Labels
bug Something isn't working ios wait for reply Further information is requested

Comments

@chrisjenx
Copy link

chrisjenx commented Dec 7, 2023

Describe the bug

See screenshot

On iOS Popups or in this case the exposed drop down is covered by the virtual keyboard on iOS. (Correct on Android).

Affected platforms
Select one of the platforms below:

  • iOS

Versions

  • Kotlin version*: 1.9.21
  • Compose Multiplatform version*: 1.5.11
  • OS version(s)* (required for Desktop and iOS issues): iOS 17.0.1 (macOS 13.6.2)
  • OS architecture (x86 or arm64): M2 (Arm64)
  • JDK (for desktop issues): Built with JDK 18

To Reproduce
Steps and/or the code snippet to reproduce the behavior:

  1. Create exposed dropdown with list longer than screen.
  2. Open keyboard on iOS, anything that drops below the keyboard is hidden behind it

Expected behavior

  • Either the Popup should go over the keyboard
  • Or pad the popup bottom so it doesn't get covered by the keyboard

Screenshots
iOS on left is covering dropdown results

image

Additional context
This Dropdown is inside BottomSheetDialogModal

Note setting windowInsetsPadding on the ExposedDropdown does help but is still covered a little:

ExposedDropdownMenu(
                expanded = expanded,
                modifier = Modifier.exposedDropdownSize().windowInsetsBottomHeight(WindowInsets.ime),
                onDismissRequest = { expanded = false },
            ) {
@chrisjenx chrisjenx added bug Something isn't working submitted labels Dec 7, 2023
@m-sasha
Copy link
Member

m-sasha commented Dec 8, 2023

Thanks for the report. We're working on placing popups and dialogs in the correct layer.

@dima-avdeev-jb
Copy link
Contributor

Thanks! I will take a look!

@dima-avdeev-jb
Copy link
Contributor

@chrisjenx Can you please provide a minimal reproducible sample on GitHub?

@ShmuelCammebys
Copy link

ShmuelCammebys commented Mar 8, 2024

So is this resolved with PR #967?

@chrisjenx
Copy link
Author

Oh looks like it should be, I need to test next time I'm on the project, the commits suggest it should

@chrisjenx
Copy link
Author

chrisjenx commented Jul 6, 2024

Still broken in 1.7.x

image

@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

@JetBrains JetBrains locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working ios wait for reply Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants