Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabStyle is mostly ignored by TabStrip and ultimately, TabImp implementation #609

Open
abarrafo opened this issue Sep 25, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@abarrafo
Copy link

If I pass in a customized TabStyle into TabStrip, it only leverages the scrollBarStyle ignoring other overrides.

I assume this is simply a, "have not gotten to it yet" issue from the team.

Here, tab style never propagates into TabImpl, instead hardcoding style to the available defaults.

@Composable
internal fun TabImpl(
    modifier: Modifier = Modifier,
    isActive: Boolean,
    tabData: TabData,
    interactionSource: MutableInteractionSource = remember { MutableInteractionSource() },
) {
    val tabStyle =
        when (tabData) {
            is TabData.Default -> JewelTheme.defaultTabStyle
            is TabData.Editor -> JewelTheme.editorTabStyle
        }
        
        ...

on a side note, great stuff team . Really like the work your doing.

@abarrafo abarrafo changed the title TabStyle is ignored by TabStrip and Ultimately, TabImp implementation TabStyle is ignored by TabStrip and ultimately, TabImp implementation Sep 25, 2024
@abarrafo abarrafo changed the title TabStyle is ignored by TabStrip and ultimately, TabImp implementation TabStyle is mostly ignored by TabStrip and ultimately, TabImp implementation Sep 25, 2024
@rock3r rock3r added the bug Something isn't working label Sep 25, 2024
@rock3r
Copy link
Collaborator

rock3r commented Sep 25, 2024

@hamen one more for the TabStrip workstream :)

@rock3r
Copy link
Collaborator

rock3r commented Sep 25, 2024

@abarrafo thanks! You're absolutely right, this is a bug :) At least it's easy to fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants