-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement storing session after restarting VSCode IDE. #11
Comments
According to microsoft/vscode#30209 and microsoft/vscode#15414 Microsoft are planning to provide a secure credential storage API in the near future. From the same thread: "VSTS Build Status extension stores password in settings currently, which is not secure." . From my perspective there are two approach: don't provide any storage till Microsoft provides any secure one OR we can implement an insecure storage and then replace it by secure when it's possible. @dtretyakov, what is your opinion? |
@rugpanov, we could try to leverage https://github.com/atom/node-keytar to store credentials until VSCode will bring own credentials store. |
@dtretyakov, I was looking at this module, but it requires python on user's PC. We discussed this problem with Igor and then I decided not to use it. I am afraid because of this problem we cannot use levelUp as well. |
@rugpanov, you could take a look at the keytar with prebuild binaries, produced by our colleague: https://www.npmjs.com/package/keytar-prebuild |
@dtretyakov, During installing by "npm install keytar-prebuild --arch=ia32" I got an error: "Can't find Python executable "python", you can set the PYTHON env variable." again. |
New error for Win10:
I've fount an closed issue: atom/node-keytar#51, but:
doesn't work for me as well. |
The discussion regarding Credentials API in VS Code: microsoft/vscode#31131 |
Just a thought: (At least with .0.0.2,) it is storing the Tc URL, username... just not the password. I don't think it's too much to ask for devs to re-enter their Tc password on restart. |
Fixed at ec6ea4b . |
The extension should store session even after restarting VSCode.
We should implement storing user credentials on a disk.
The text was updated successfully, but these errors were encountered: