fix date condition logic (#510)

Co-authored-by: Julien Nahum <julien@nahum.net>

Author: madassdev

app/Service/Forms/FormLogicConditionChecker.php

@@ -148,22 +148,22 @@ private function checkLessThanEqual($condition, $fieldValue): bool
 
     private function checkBefore($condition, $fieldValue): bool
     {
-        return $condition['value'] && $fieldValue && $fieldValue > $condition['value'];
+        return $condition['value'] && $fieldValue && $fieldValue < $condition['value'];
     }
 
     private function checkAfter($condition, $fieldValue): bool
     {
-        return $condition['value'] && $fieldValue && $fieldValue < $condition['value'];
+        return $condition['value'] && $fieldValue && $fieldValue > $condition['value'];
     }
 
     private function checkOnOrBefore($condition, $fieldValue): bool
     {
-        return $condition['value'] && $fieldValue && $fieldValue >= $condition['value'];
+        return $condition['value'] && $fieldValue && $fieldValue <= $condition['value'];
     }
 
     private function checkOnOrAfter($condition, $fieldValue): bool
     {
-        return $condition['value'] && $fieldValue && $fieldValue <= $condition['value'];
+        return $condition['value'] && $fieldValue && $fieldValue >= $condition['value'];
     }
 
     private function checkPastWeek($condition, $fieldValue): bool

client/lib/forms/FormLogicConditionChecker.js

@@ -126,19 +126,19 @@ function checkLessThanEqual(condition, fieldValue) {
 }
 
 function checkBefore(condition, fieldValue) {
-  return condition.value && fieldValue && fieldValue > condition.value
+  return condition.value && fieldValue && fieldValue < condition.value
 }
 
 function checkAfter(condition, fieldValue) {
-  return condition.value && fieldValue && fieldValue < condition.value
+  return condition.value && fieldValue && fieldValue > condition.value
 }
 
 function checkOnOrBefore(condition, fieldValue) {
-  return condition.value && fieldValue && fieldValue >= condition.value
+  return condition.value && fieldValue && fieldValue <= condition.value
 }
 
 function checkOnOrAfter(condition, fieldValue) {
-  return condition.value && fieldValue && fieldValue <= condition.value
+  return condition.value && fieldValue && fieldValue >= condition.value
 }
 
 function checkPastWeek(condition, fieldValue) {