Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padding type for generator #40

Open
XiaoGene opened this issue May 22, 2018 · 4 comments
Open

padding type for generator #40

XiaoGene opened this issue May 22, 2018 · 4 comments
Labels
good first issue Good for newcomers

Comments

@XiaoGene
Copy link

In the paper, it is written in Section 3 that "we use mirror padding for all convolution layers". However, the code seem to use 'SAME' padding (i.e. zero padding) for the generator since the 'PADDING' field of the .yml file is specified as 'SAME'. Which type of padding did you use exactly for the pretrained models?

Thank you for your help!

@JiahuiYu
Copy link
Owner

Thanks for point out the typo. The answer is we use 'SAME' padding.

The story is: during earlier development of this work, we use mirror padding. However, we find this is almost equivalent to concatenate ones (indicating the boundaries of images) as input. See line here.

@XiaoGene
Copy link
Author

Thanks for the answer! But why does concatenating ones as a channel indicates the boundaries of images?

@JiahuiYu
Copy link
Owner

Because the convolution automatically pad zeros as in 'SAME' mode.

@XiaoGene
Copy link
Author

Ok, I see what you mean. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants