-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
padding type for generator #40
Comments
Thanks for point out the typo. The answer is we use 'SAME' padding. The story is: during earlier development of this work, we use mirror padding. However, we find this is almost equivalent to concatenate ones (indicating the boundaries of images) as input. See line here. |
Thanks for the answer! But why does concatenating ones as a channel indicates the boundaries of images? |
Because the convolution automatically pad zeros as in 'SAME' mode. |
Ok, I see what you mean. Thanks! |
In the paper, it is written in Section 3 that "we use mirror padding for all convolution layers". However, the code seem to use 'SAME' padding (i.e. zero padding) for the generator since the 'PADDING' field of the .yml file is specified as 'SAME'. Which type of padding did you use exactly for the pretrained models?
Thank you for your help!
The text was updated successfully, but these errors were encountered: