Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary files created by ArtifactBuilder persist even without building #164

Open
Shitaro opened this issue Nov 27, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Shitaro
Copy link
Collaborator

Shitaro commented Nov 27, 2024

I encountered an issue while trying to create an Artifact Archive file using the ArtifactBuilder class. When calling ArtifactBuilder.new_archive, an empty file is immediately created locally.

I expected this empty file to be automatically removed if the ArtifactBuilder.build method was not subsequently called. However, the file remains on the system. Even deleting the ArtifactBuilder object does not change this behavior.

Is this the intended behavior, or should this be considered a bug that needs fixing?

Below is the code to reproduce the issue:

from ommx.artifact import ArtifactBuilder

tag = "test"
filename = f"my_instance.ommx.{tag}"
image_name = f"my_instance:{tag}"

builder = ArtifactBuilder.new_archive(filename, image_name)
del(builder)  # Delete the object without calling build()

image

@Shitaro Shitaro added the bug Something isn't working label Nov 27, 2024
@Shitaro Shitaro changed the title Temporary files created by ArtifactBuilder persist even without building Temporary files created by ArtifactBuilder persist even without building Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant