Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query regarding run.py : inputs_3d[:, :, 0] = 0 #18

Open
RHnejad opened this issue Oct 21, 2022 · 3 comments
Open

Query regarding run.py : inputs_3d[:, :, 0] = 0 #18

RHnejad opened this issue Oct 21, 2022 · 3 comments

Comments

@RHnejad
Copy link

RHnejad commented Oct 21, 2022

Thanks for sharing your interesting work.

Can I ask the reasoning behind inputs_3d[:, :, 0] = 0 ? Considering that it's one of the desired outputs.

@Z-Z-J
Copy link

Z-Z-J commented Oct 22, 2022

In the process of processing data (run.py line: 114), they remove global offset, but keep trajectory in first position. Because in previous works, such as Videopose3d, these works need to estimate root trajectory (input_3d[:, :, 0]). But in this work, they only estimate root-relative 3D pose, so need input_3d[:, :, 0] = 0

@RHnejad
Copy link
Author

RHnejad commented Oct 23, 2022

Hello and thanks for the answer.
Do you also know why they aren't excluding this output completely? Wouldn't it be helpful to estimate the 3D keypoints of 16 joints instead, if this one is always known and expected to be zero?

@Z-Z-J
Copy link

Z-Z-J commented Oct 24, 2022

Hello and thanks for the answer. Do you also know why they aren't excluding this output completely? Wouldn't it be helpful to estimate the 3D keypoints of 16 joints instead, if this one is always known and expected to be zero?

You can run the training code and find the estimation error of the root joint is close to zero, so it is not necessary to exclude the root joint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants