Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out polys with NaN normals indicating degenerate polygons in m… #30

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Filter out polys with NaN normals indicating degenerate polygons in m… #30

merged 3 commits into from
Jun 22, 2021

Conversation

manthrax
Copy link
Collaborator

…esh.

I haven't tested this thoroughly.. but it should improve robustness for malformed input meshes.

@manthrax manthrax requested a review from samalexander June 21, 2021 18:34
@manthrax manthrax mentioned this pull request Jun 21, 2021
Closed
@samalexander
fix access to normal property
2ee5097 
`p.normal` is undefined, should be `p.plane.normal`.
@samalexander
Copy link
Owner

samalexander commented Jun 22, 2021 •
edited
Loading

Thanks @manthrax!

Confirmed this appears to fix @steveliles test case from #21.

Large GIF (752x184)

samalexander
samalexander previously approved these changes Jun 22, 2021
View reviewed changes
Copy link
Owner

@samalexander samalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samalexander samalexander merged commit b835954 into master Jun 22, 2021
@samalexander samalexander deleted the filter-degenerate branch June 22, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samalexander samalexander samalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manthrax @samalexander