Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple message while reading TOC #257

Closed
ghost opened this issue Mar 17, 2018 · 1 comment
Closed

Simple message while reading TOC #257

ghost opened this issue Mar 17, 2018 · 1 comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@ghost
Copy link

ghost commented Mar 17, 2018

Hello,
as I already stated in some mash-up issue earlier, when whipper starts reading the TOC, it may seems frozen/stuck to profanes, so some message would be quite helpful. Here's some patch I made (bear with it, I don't know Python) that should get the idea across:

diff --git a/whipper/command/cd.py b/whipper/command/cd.py
index e467540..8aaea48 100644
--- a/whipper/command/cd.py
+++ b/whipper/command/cd.py
@@ -98,6 +98,7 @@ class _CD(BaseCommand):
         utils.unmount_device(self.device)

         # first, read the normal TOC, which is fast
+        sys.stdout.write("Reading TOC...")
         self.ittoc = self.program.getFastToc(self.runner, self.device)

         # already show us some info based on this
@RecursiveForest
Copy link
Contributor

I've created a pull request for the other developers to sign off on at #258 ; this looks good to me, thanks for submitting a patch!

@JoeLametta JoeLametta added this to the v0.7.0 milestone Mar 22, 2018
@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Improvement Minor improvement to code and removed enhancement labels Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

2 participants