Detect and handle CD-R discs

[gorgobacka]

This PR uses cdrdao to detect CD-R discs as discussed in #137 and stops the ripping process with a warning message. The parameter '--cdr' is required to rip this discs (similar to the '--unknown' parameter), indicating that the user should be sure that the inserted medium is reliable.

Additionally, the disc format is added to the output of 'Matching releases' to give the user more information.

Possible enhancements: add this information also to the logger.

[JoeLametta]

Possible enhancements: add this information also to the logger.

Yep, apart from that it LGTM.

😉

[gorgobacka]

Thanks for your comment. I prepared an update.

[gorgobacka]

@JoeLametta I would like to know, what do you think about the my update. And I'm wondering, if there are any additional improvements needed before it can be merged.

[JoeLametta]

I would like to know, what do you think about the my update. And I'm wondering, if there are any additional improvements needed before it can be merged.

I tested it yesterday and the feature seems to be working correctly. Here are the changes I'd like to be implemented before merging:

1. Rebase (there are conflicts)
2. PEP8 fix the PR (the whole codebase was recently made compliant)
3. Remove the MusicBrainz medium format thing (maybe propose it in a separate PR?)

Thanks,
Joe

[gorgobacka]

Thanks for your fast reply and the constructive comments. I will provide an update over the weekend.

[JoeLametta]

I think it's better if you break it like this:

        if (self.program.result.isCdr and
                not getattr(self.options, 'cdr', False)):

[JoeLametta]

Everything else is OK

[gorgobacka]

Indeed it looks better. Updated.

[JoeLametta]

Merged, thanks.

😉