Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small readme cleanups #250

Merged
merged 6 commits into from
Mar 22, 2018

Conversation

RecursiveForest
Copy link
Contributor

I think the only controversial thing here is the removal of the "backwards incompatible changes" section. As we grow into our own application, not merely a fork of morituri, I don't think it's useful to keep a manually updated list of changes in the README. The changelog / git history should suffice.

	- remove backwards incompatible changes section
	- add note about adding and running tests for devs
	- remove mention of incomplete man page
	- remove mention of force-pushed non-master branches
@@ -1,6 +1,12 @@
# Whipper

[![license](https://img.shields.io/github/license/JoeLametta/whipper.svg)](https://github.com/JoeLametta/whipper/blob/master/LICENSE) [![Build Status](https://travis-ci.org/JoeLametta/whipper.svg?branch=master)](https://travis-ci.org/JoeLametta/whipper) [![GitHub (pre-)release](https://img.shields.io/github/release/joelametta/whipper/all.svg)](https://github.com/JoeLametta/whipper/releases/latest) [![IRC](https://img.shields.io/badge/irc-%23whipper%40freenode-brightgreen.svg)](https://webchat.freenode.net/?channels=%23whipper) [![GitHub Stars](https://img.shields.io/github/stars/JoeLametta/whipper.svg)](https://github.com/JoeLametta/whipper/stargazers) [![GitHub Issues](https://img.shields.io/github/issues/JoeLametta/whipper.svg)](https://github.com/JoeLametta/whipper/issues) [![GitHub contributors](https://img.shields.io/github/contributors/JoeLametta/whipper.svg)](https://github.com/JoeLametta/whipper/graphs/contributors)
[![license](https://img.shields.io/github/license/JoeLametta/whipper.svg)](https://github.com/JoeLametta/whipper/blob/master/LICENSE)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these render the same but are easier to read/edit in plaintext broken up like this into separate lines.

@@ -126,8 +130,6 @@ is correct, while

is not, because the `-d` argument applies to the `cd` command.

~~Check the man page (`whipper(1)`) for more information.~~ (currently not available as whipper's documentation is planned to be reworked ([Issue #73](https://github.com/JoeLametta/whipper/issues/73))).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add mention of a man page when we have one, but I don't think there's any need to call attention to the fact that it's a planned feature.

Pull requests are welcome.

**WARNING:** As whipper is still under heavy development sometimes I will force push (`--force-with-lease`) to the non master branches.

## Credits
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sort of want to delete this section, as it's easy to see in the git history who the developers are, and we already have all these names (+ Freso's now) in the copyright section.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MerlijnWajer
Copy link
Collaborator

MerlijnWajer commented Mar 5, 2018

I'd suggest to keep the ones in the README too. Many people don't get the git history when they're on their distro, but distros can often ship a README. Maybe the soon to be created manpage is another place for this?

@RecursiveForest
Copy link
Contributor Author

I think the copyright/license file is the right place to keep information about copyright holders and developers; at the bottom of the man page is definitely a relevant place for it though, at least by standard.

I don't see many FOSS projects listing contributors in the README, which tends to be need-to-know-to-help-the-user information.

@MerlijnWajer
Copy link
Collaborator

It's particularly helpful if you want to find maintainers of software, though. And we should be doing this in each file (copyright header) too, with name and email addr.

@RecursiveForest
Copy link
Contributor Author

I've restored the Credits section and resolved the conflicts with master.

Copy link
Collaborator

@MerlijnWajer MerlijnWajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me now.

@JoeLametta JoeLametta merged commit 1ba0132 into whipper-team:master Mar 22, 2018
@JoeLametta
Copy link
Collaborator

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants