Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifiers issues #5

Closed
Jofairden opened this issue Apr 7, 2018 · 0 comments
Closed

Modifiers issues #5

Jofairden opened this issue Apr 7, 2018 · 0 comments
Assignees

Comments

@Jofairden
Copy link
Owner

For modifiers, you cannot save/load data by item instance (see default methods)
Proposed change is to have save/load accept the item instance

Currently sealed hooks should be made available (where applicable) with proper implementation. For example WingUpdate should be available.

The tML clone method will not work, its signature differs from the ICloneable one:
public sealed override GlobalItem Clone(Item item, Item itemClone) => base.Clone(item, itemClone);
It should be reimplemented

Modders' save and load should keep bad code in mind (exceptions), proposed is to surround them in a try - catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant