Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Ctrl + Alt + alphabetic key shortcut won't work on Firefox on some international layouts #1077

Open
zkriszti opened this issue Sep 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@zkriszti
Copy link

Describe the bug
Ctrl + Alt + [alphabetic key] shortcut won't work on Firefox on some international layouts

To Reproduce
Steps to reproduce the behavior:

  1. create a simple React project with react-hotkeys-hook imported
  2. create a shortcut (ie. Ctrl + Alt + G)
  3. open the project in Firefox and switch to international keyboard layout (ie. reproducible with HUN)
  4. the callback function won't fire

Please try and add a codesandbox or stackblitz to reproduce the bug:
https://stackblitz.com/edit/stackblitz-starters-sf7qr6?file=src%2FApp.js

Expected behavior
The callback function should trigger when using the given shortcut.

Desktop (please complete the following information):

  • OS: Windows11
  • Browser: Firefox Developer Edition 118.0b9 (64-bit)
  • Version: 4.4.1

Additional context
Interestingly, the problem is not present when using hotkeys-js. They seem to have a PR that solved the similar problem:
jaywcjlove/hotkeys-js#129
https://github.com/jaywcjlove/hotkeys-js/blob/031bc4d5da583ca07f1e7b26bce83d3da409c6ad/src/index.js#L281

@JohannesKlauss JohannesKlauss added the bug Something isn't working label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants