Example app causes javascript error using latest dev version

[daattali]

Running the sample code from the README using the latest github version results in a javascript error that prevents the page from working:

library(shiny)
library(waiter)

ui <- fluidPage(
    use_waiter(), # include dependencies
    waiter_show_on_load(),
    actionButton("show", "Show loading for 3 seconds")
)

server <- function(input, output, session){
    
    observeEvent(input$show, {
        
        waiter_show( # show the waiter
            spin_fading_circles() # use a spinner
        )
        
        Sys.sleep(3) # do something that takes time
        
        waiter_hide() # hide the waiter
    })
    
}

shinyApp(ui, server)

JS error:

Uncaught TypeError: Shiny.setInputValue is not a function
at show_waiter (waiter.js:111)
at (index):28

Looks like perhaps it's trying to run before shiny loads

[JohnCoene]

Yes indeed, thanks for reporting this Dean! setInputValue before shiny connected.

Moreover there is an issue in the example which runs waiter_show_on_load but never calls waiter_hide; hence the infinite loading screen.

library(shiny)
library(waiter)

ui <- fluidPage(
    use_waiter(), # include dependencies
    actionButton("show", "Show loading for 3 seconds")
)

server <- function(input, output, session){
    
    observeEvent(input$show, {
        
        waiter_show( # show the waiter
            spin_fading_circles() # use a spinner
        )
        
        Sys.sleep(3) # do something that takes time
        
        waiter_hide() # hide the waiter
    })
    
}

shinyApp(ui, server)