Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symmetric SpellChecker:Missing default values #1121

Open
ibychkov007 opened this issue Oct 30, 2020 · 1 comment
Open

Symmetric SpellChecker:Missing default values #1121

ibychkov007 opened this issue Oct 30, 2020 · 1 comment
Assignees
Labels

Comments

@ibychkov007
Copy link

Description

SymmetricDeleteModel.load("//spellcheck_sd_en_2.0.2_2.4_1556604489934")
.setInputCols(Array(context.inputField))
.setOutputCol(context.outputField + "_token")
.setDupsLimit(2) //error
.setFrequencyThreshold(0)
.setMaxEditDistance(3)
.setDeletesThreshold(0)
.setMaxFrequency(10) //error
.setMinFrequency(1) //error
Unless i set values for setDupsLimit/setMaxFrequency/setMinFrequency it fails with error complaining that default value is missing. For rest of parameters I am using default values I've discovered in source code. How should i set those parameters causing error? SHoudl spark NLP have default values for them?

Expected Behavior

setDupsLimit/setMaxFrequency/setMinFrequency should be used to fine tune default values - SymmetricDeleteModel should work using defauts values for them

Current Behavior

Failures becasue of missinf default values

Possible Solution

Steps to Reproduce

Context

Your Environment

  • Spark NLP version: 2.6.3
  • Apache NLP version:
  • Java version (java -version):1.8
  • Setup and installation (Pypi, Conda, Maven, etc.):
  • Operating System and version:
  • Link to your project (if any):
@maziyarpanahi
Copy link
Member

Thanks for reporting this, every annotator should work without any parameters. So the default values are missing and they are required. I'll take a look for the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants