Skip to content

Commit 281aa31

Browse files
committed
1 parent 10cf141 commit 281aa31

File tree

150 files changed

+301
-451
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

150 files changed

+301
-451
lines changed

clippy_lints/src/approx_const.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
use crate::utils::span_lint;
2-
use rustc::declare_lint_pass;
3-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
2+
use rustc::lint::{LateContext, LateLintPass};
43
use rustc_hir::*;
5-
use rustc_session::declare_tool_lint;
4+
use rustc_session::{declare_lint_pass, declare_tool_lint};
65
use rustc_span::symbol;
76
use std::f64::consts as f64;
87
use syntax::ast::{FloatTy, LitFloatType, LitKind};

clippy_lints/src/arithmetic.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
use crate::consts::constant_simple;
22
use crate::utils::span_lint;
3-
use rustc::impl_lint_pass;
4-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
3+
use rustc::lint::{LateContext, LateLintPass};
54
use rustc_hir as hir;
6-
use rustc_session::declare_tool_lint;
5+
use rustc_session::{declare_tool_lint, impl_lint_pass};
76
use rustc_span::source_map::Span;
87

98
declare_clippy_lint! {

clippy_lints/src/as_conversions.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
use rustc::declare_lint_pass;
2-
use rustc::lint::{in_external_macro, EarlyContext, EarlyLintPass, LintArray, LintContext, LintPass};
3-
use rustc_session::declare_tool_lint;
1+
use rustc::lint::{in_external_macro, EarlyContext, EarlyLintPass, LintContext};
2+
use rustc_session::{declare_lint_pass, declare_tool_lint};
43
use syntax::ast::*;
54

65
use crate::utils::span_help_and_lint;

clippy_lints/src/assertions_on_constants.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@ use crate::consts::{constant, Constant};
22
use crate::utils::paths;
33
use crate::utils::{is_direct_expn_of, is_expn_of, match_function_call, snippet_opt, span_help_and_lint};
44
use if_chain::if_chain;
5-
use rustc::declare_lint_pass;
6-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
5+
use rustc::lint::{LateContext, LateLintPass};
76
use rustc_hir::*;
8-
use rustc_session::declare_tool_lint;
7+
use rustc_session::{declare_lint_pass, declare_tool_lint};
98
use syntax::ast::LitKind;
109

1110
declare_clippy_lint! {

clippy_lints/src/assign_ops.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,12 @@ use crate::utils::{
33
};
44
use crate::utils::{higher, sugg};
55
use if_chain::if_chain;
6-
use rustc::declare_lint_pass;
76
use rustc::hir::map::Map;
8-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
7+
use rustc::lint::{LateContext, LateLintPass};
98
use rustc_errors::Applicability;
109
use rustc_hir as hir;
1110
use rustc_hir::intravisit::{walk_expr, NestedVisitorMap, Visitor};
12-
use rustc_session::declare_tool_lint;
11+
use rustc_session::{declare_lint_pass, declare_tool_lint};
1312

1413
declare_clippy_lint! {
1514
/// **What it does:** Checks for `a = a op b` or `a = b commutative_op a`

clippy_lints/src/atomic_ordering.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
use crate::utils::{match_def_path, span_help_and_lint};
22
use if_chain::if_chain;
3-
use rustc::declare_lint_pass;
4-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
3+
use rustc::lint::{LateContext, LateLintPass};
54
use rustc::ty;
65
use rustc_hir::def_id::DefId;
76
use rustc_hir::*;
8-
use rustc_session::declare_tool_lint;
7+
use rustc_session::{declare_lint_pass, declare_tool_lint};
98

109
declare_clippy_lint! {
1110
/// **What it does:** Checks for usage of invalid atomic

clippy_lints/src/attrs.rs

+3-4
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,14 @@ use crate::utils::{
66
span_lint_and_then, without_block_comments,
77
};
88
use if_chain::if_chain;
9-
use rustc::declare_lint_pass;
109
use rustc::lint::{
11-
in_external_macro, CheckLintNameResult, EarlyContext, EarlyLintPass, LateContext, LateLintPass, LintArray,
12-
LintContext, LintPass,
10+
in_external_macro, CheckLintNameResult, EarlyContext, EarlyLintPass, LateContext, LateLintPass,
11+
LintContext,
1312
};
1413
use rustc::ty;
1514
use rustc_errors::Applicability;
1615
use rustc_hir::*;
17-
use rustc_session::declare_tool_lint;
16+
use rustc_session::{declare_lint_pass, declare_tool_lint};
1817
use rustc_span::source_map::Span;
1918
use rustc_span::symbol::Symbol;
2019
use semver::Version;

clippy_lints/src/bit_mask.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,10 @@ use crate::consts::{constant, Constant};
22
use crate::utils::sugg::Sugg;
33
use crate::utils::{span_lint, span_lint_and_then};
44
use if_chain::if_chain;
5-
use rustc::impl_lint_pass;
6-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
5+
use rustc::lint::{LateContext, LateLintPass};
76
use rustc_errors::Applicability;
87
use rustc_hir::*;
9-
use rustc_session::declare_tool_lint;
8+
use rustc_session::{declare_tool_lint, impl_lint_pass};
109
use rustc_span::source_map::Span;
1110
use syntax::ast::LitKind;
1211

clippy_lints/src/blacklisted_name.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
use crate::utils::span_lint;
2-
use rustc::impl_lint_pass;
3-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
2+
use rustc::lint::{LateContext, LateLintPass};
43
use rustc_data_structures::fx::FxHashSet;
54
use rustc_hir::*;
6-
use rustc_session::declare_tool_lint;
5+
use rustc_session::{declare_tool_lint, impl_lint_pass};
76

87
declare_clippy_lint! {
98
/// **What it does:** Checks for usage of blacklisted names for variables, such

clippy_lints/src/block_in_if_condition.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
use crate::utils::*;
22
use matches::matches;
3-
use rustc::declare_lint_pass;
43
use rustc::hir::map::Map;
5-
use rustc::lint::{in_external_macro, LateContext, LateLintPass, LintArray, LintContext, LintPass};
4+
use rustc::lint::{in_external_macro, LateContext, LateLintPass, LintContext};
65
use rustc_hir::intravisit::{walk_expr, NestedVisitorMap, Visitor};
76
use rustc_hir::*;
8-
use rustc_session::declare_tool_lint;
7+
use rustc_session::{declare_lint_pass, declare_tool_lint};
98

109
declare_clippy_lint! {
1110
/// **What it does:** Checks for `if` conditions that use blocks to contain an

clippy_lints/src/booleans.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,13 @@ use crate::utils::{
33
span_lint_and_then, SpanlessEq,
44
};
55
use if_chain::if_chain;
6-
use rustc::declare_lint_pass;
76
use rustc::hir::map::Map;
8-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
7+
use rustc::lint::{LateContext, LateLintPass};
98
use rustc_errors::Applicability;
109
use rustc_hir::intravisit;
1110
use rustc_hir::intravisit::*;
1211
use rustc_hir::*;
13-
use rustc_session::declare_tool_lint;
12+
use rustc_session::{declare_lint_pass, declare_tool_lint};
1413
use rustc_span::source_map::Span;
1514
use syntax::ast::LitKind;
1615

clippy_lints/src/bytecount.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,11 @@ use crate::utils::{
33
span_lint_and_sugg, walk_ptrs_ty,
44
};
55
use if_chain::if_chain;
6-
use rustc::declare_lint_pass;
7-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
6+
use rustc::lint::{LateContext, LateLintPass};
87
use rustc::ty;
98
use rustc_errors::Applicability;
109
use rustc_hir::*;
11-
use rustc_session::declare_tool_lint;
10+
use rustc_session::{declare_lint_pass, declare_tool_lint};
1211
use syntax::ast::{Name, UintTy};
1312

1413
declare_clippy_lint! {

clippy_lints/src/cargo_common_metadata.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33
use std::path::PathBuf;
44

55
use crate::utils::span_lint;
6-
use rustc::declare_lint_pass;
7-
use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
8-
use rustc_session::declare_tool_lint;
6+
use rustc::lint::{EarlyContext, EarlyLintPass};
7+
use rustc_session::{declare_lint_pass, declare_tool_lint};
98
use rustc_span::source_map::DUMMY_SP;
109
use syntax::ast::*;
1110

clippy_lints/src/checked_conversions.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
//! lint on manually implemented checked conversions that could be transformed into `try_from`
22
33
use if_chain::if_chain;
4-
use rustc::declare_lint_pass;
5-
use rustc::lint::{in_external_macro, LateContext, LateLintPass, LintArray, LintContext, LintPass};
4+
use rustc::lint::{in_external_macro, LateContext, LateLintPass, LintContext};
65
use rustc_errors::Applicability;
76
use rustc_hir::*;
8-
use rustc_session::declare_tool_lint;
7+
use rustc_session::{declare_lint_pass, declare_tool_lint};
98
use syntax::ast::LitKind;
109

1110
use crate::utils::{snippet_with_applicability, span_lint_and_sugg, SpanlessEq};

clippy_lints/src/cognitive_complexity.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
//! calculate cognitive complexity and warn about overly complex functions
22
33
use rustc::hir::map::Map;
4-
use rustc::impl_lint_pass;
5-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintContext, LintPass};
4+
use rustc::lint::{LateContext, LateLintPass, LintContext};
65
use rustc_hir::intravisit::{walk_expr, FnKind, NestedVisitorMap, Visitor};
76
use rustc_hir::*;
8-
use rustc_session::declare_tool_lint;
7+
use rustc_session::{declare_tool_lint, impl_lint_pass};
98
use rustc_span::source_map::Span;
109
use rustc_span::BytePos;
1110
use syntax::ast::Attribute;

clippy_lints/src/collapsible_if.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,8 @@
1313
//! This lint is **warn** by default
1414
1515
use if_chain::if_chain;
16-
use rustc::declare_lint_pass;
17-
use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
18-
use rustc_session::declare_tool_lint;
16+
use rustc::lint::{EarlyContext, EarlyLintPass};
17+
use rustc_session::{declare_lint_pass, declare_tool_lint};
1918
use syntax::ast;
2019

2120
use crate::utils::sugg::Sugg;

clippy_lints/src/comparison_chain.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
use crate::utils::{
22
get_trait_def_id, if_sequence, implements_trait, parent_node_is_if_expr, paths, span_help_and_lint, SpanlessEq,
33
};
4-
use rustc::declare_lint_pass;
5-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
4+
use rustc::lint::{LateContext, LateLintPass};
65
use rustc_hir::*;
7-
use rustc_session::declare_tool_lint;
6+
use rustc_session::{declare_lint_pass, declare_tool_lint};
87

98
declare_clippy_lint! {
109
/// **What it does:** Checks comparison chains written with `if` that can be

clippy_lints/src/copies.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
use crate::utils::{get_parent_expr, higher, if_sequence, same_tys, snippet, span_lint_and_then, span_note_and_lint};
22
use crate::utils::{SpanlessEq, SpanlessHash};
3-
use rustc::declare_lint_pass;
4-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
3+
use rustc::lint::{LateContext, LateLintPass};
54
use rustc::ty::Ty;
65
use rustc_data_structures::fx::FxHashMap;
76
use rustc_hir::*;
8-
use rustc_session::declare_tool_lint;
7+
use rustc_session::{declare_lint_pass, declare_tool_lint};
98
use rustc_span::symbol::Symbol;
109
use std::collections::hash_map::Entry;
1110
use std::hash::BuildHasherDefault;

clippy_lints/src/copy_iterator.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
use crate::utils::{is_copy, match_path, paths, span_note_and_lint};
2-
use rustc::declare_lint_pass;
3-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
2+
use rustc::lint::{LateContext, LateLintPass};
43
use rustc_hir::{Item, ItemKind};
5-
use rustc_session::declare_tool_lint;
4+
use rustc_session::{declare_lint_pass, declare_tool_lint};
65

76
declare_clippy_lint! {
87
/// **What it does:** Checks for types that implement `Copy` as well as

clippy_lints/src/dbg_macro.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
use crate::utils::{snippet_opt, span_help_and_lint, span_lint_and_sugg};
2-
use rustc::declare_lint_pass;
3-
use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
2+
use rustc::lint::{EarlyContext, EarlyLintPass};
43
use rustc_errors::Applicability;
5-
use rustc_session::declare_tool_lint;
4+
use rustc_session::{declare_lint_pass, declare_tool_lint};
65
use rustc_span::source_map::Span;
76
use syntax::ast;
87
use syntax::tokenstream::TokenStream;

clippy_lints/src/default_trait_access.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
use if_chain::if_chain;
2-
use rustc::declare_lint_pass;
3-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
2+
use rustc::lint::{LateContext, LateLintPass};
43
use rustc::ty;
54
use rustc_errors::Applicability;
65
use rustc_hir::*;
7-
use rustc_session::declare_tool_lint;
6+
use rustc_session::{declare_lint_pass, declare_tool_lint};
87

98
use crate::utils::{any_parent_is_automatically_derived, match_def_path, paths, span_lint_and_sugg};
109

clippy_lints/src/derive.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
use crate::utils::paths;
22
use crate::utils::{is_automatically_derived, is_copy, match_path, span_lint_and_then};
33
use if_chain::if_chain;
4-
use rustc::declare_lint_pass;
5-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
4+
use rustc::lint::{LateContext, LateLintPass};
65
use rustc::ty::{self, Ty};
76
use rustc_hir::*;
8-
use rustc_session::declare_tool_lint;
7+
use rustc_session::{declare_lint_pass, declare_tool_lint};
98
use rustc_span::source_map::Span;
109

1110
declare_clippy_lint! {

clippy_lints/src/doc.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
use crate::utils::{match_type, paths, return_ty, span_lint};
22
use itertools::Itertools;
3-
use rustc::impl_lint_pass;
4-
use rustc::lint::{in_external_macro, LateContext, LateLintPass, LintArray, LintPass};
3+
use rustc::lint::{in_external_macro, LateContext, LateLintPass};
54
use rustc_data_structures::fx::FxHashSet;
65
use rustc_hir as hir;
7-
use rustc_session::declare_tool_lint;
6+
use rustc_session::{declare_tool_lint, impl_lint_pass};
87
use rustc_span::source_map::{BytePos, MultiSpan, Span};
98
use rustc_span::Pos;
109
use std::ops::Range;

clippy_lints/src/double_comparison.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
//! Lint on unnecessary double comparisons. Some examples:
22
3-
use rustc::declare_lint_pass;
4-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
3+
use rustc::lint::{LateContext, LateLintPass};
54
use rustc_errors::Applicability;
65
use rustc_hir::*;
7-
use rustc_session::declare_tool_lint;
6+
use rustc_session::{declare_lint_pass, declare_tool_lint};
87
use rustc_span::source_map::Span;
98

109
use crate::utils::{snippet_with_applicability, span_lint_and_sugg, SpanlessEq};

clippy_lints/src/double_parens.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
use crate::utils::span_lint;
2-
use rustc::declare_lint_pass;
3-
use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintPass};
4-
use rustc_session::declare_tool_lint;
2+
use rustc::lint::{EarlyContext, EarlyLintPass};
3+
use rustc_session::{declare_lint_pass, declare_tool_lint};
54
use syntax::ast::*;
65

76
declare_clippy_lint! {

clippy_lints/src/drop_bounds.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
use crate::utils::{match_def_path, paths, span_lint};
22
use if_chain::if_chain;
3-
use rustc::declare_lint_pass;
4-
use rustc::lint::{LateLintPass, LintArray, LintPass};
3+
use rustc::lint::LateLintPass;
54
use rustc_hir::*;
6-
use rustc_session::declare_tool_lint;
5+
use rustc_session::{declare_lint_pass, declare_tool_lint};
76

87
declare_clippy_lint! {
98
/// **What it does:** Checks for generics with `std::ops::Drop` as bounds.

clippy_lints/src/drop_forget_ref.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
use crate::utils::{is_copy, match_def_path, paths, qpath_res, span_note_and_lint};
22
use if_chain::if_chain;
3-
use rustc::declare_lint_pass;
4-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
3+
use rustc::lint::{LateContext, LateLintPass};
54
use rustc::ty;
65
use rustc_hir::*;
7-
use rustc_session::declare_tool_lint;
6+
use rustc_session::{declare_lint_pass, declare_tool_lint};
87

98
declare_clippy_lint! {
109
/// **What it does:** Checks for calls to `std::mem::drop` with a reference

clippy_lints/src/duration_subsec.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
use if_chain::if_chain;
2-
use rustc::declare_lint_pass;
3-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
2+
use rustc::lint::{LateContext, LateLintPass};
43
use rustc_errors::Applicability;
54
use rustc_hir::*;
6-
use rustc_session::declare_tool_lint;
5+
use rustc_session::{declare_lint_pass, declare_tool_lint};
76
use rustc_span::source_map::Spanned;
87

98
use crate::consts::{constant, Constant};

clippy_lints/src/else_if_without_else.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
//! Lint on if expressions with an else if, but without a final else branch.
22
3-
use rustc::declare_lint_pass;
4-
use rustc::lint::{in_external_macro, EarlyContext, EarlyLintPass, LintArray, LintContext, LintPass};
5-
use rustc_session::declare_tool_lint;
3+
use rustc::lint::{in_external_macro, EarlyContext, EarlyLintPass, LintContext};
4+
use rustc_session::{declare_lint_pass, declare_tool_lint};
65
use syntax::ast::*;
76

87
use crate::utils::span_help_and_lint;

clippy_lints/src/empty_enum.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
//! lint when there is an enum with no variants
22
33
use crate::utils::span_lint_and_then;
4-
use rustc::declare_lint_pass;
5-
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
4+
use rustc::lint::{LateContext, LateLintPass};
65
use rustc_hir::*;
7-
use rustc_session::declare_tool_lint;
6+
use rustc_session::{declare_lint_pass, declare_tool_lint};
87

98
declare_clippy_lint! {
109
/// **What it does:** Checks for `enum`s with no variants.

0 commit comments

Comments
 (0)