Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Settings do not save #739

Closed
v-champion opened this issue Aug 14, 2024 · 2 comments
Closed

Plugin Settings do not save #739

v-champion opened this issue Aug 14, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers plugin Related to Roblox Studio Plugin pr welcome We would support a contribution for this change

Comments

@v-champion
Copy link

When accessing plugin settings from the toolbar button, any changes you make will not save.

Example steps taken:

  1. Open your place using Roblox Studio
  2. Edit the settings script i.e. startAutomatically = true,
  3. Close the place, then open it again
  4. Settings reset back to default
@JohnnyMorganz JohnnyMorganz added bug Something isn't working plugin Related to Roblox Studio Plugin labels Sep 11, 2024
@JohnnyMorganz JohnnyMorganz added pr welcome We would support a contribution for this change good first issue Good for newcomers labels Nov 10, 2024
@TaylorsRus
Copy link

plugin is looking for a plugin module script as child of AnalyticsService, any reason it's doing this instead of just saving the source as a plugin setting? Script doesn't even save anything to AnalyticsService, but there's clear intent that it was going to

@v-champion
Copy link
Author

v-champion commented Nov 13, 2024

plugin is looking for a plugin module script as child of AnalyticsService, any reason it's doing this instead of just saving the source as a plugin setting? Script doesn't even save anything to AnalyticsService, but there's clear intent that it was going to

From what I understand, the original intent was for the module script to be parented to AnalyticsService because it's hidden and out of the way, and the instance persisted so that it could be re-used for future studio sessions. I guess what's happening now is that the latter is no longer the case. Therefore, the module must be parented elsewhere to be preserved (i.e. TestService).

Alternatively, your idea works too-- however, this would require important changes and decision-making beyond the scope of this bug report. There are a few things to consider:

What would be the criteria behind how/where plugin settings will persist? game.PlaceId? game.GameId (universal settings between multi-place experiences) or lastly, settings save universally (across all experiences edited). I think it's a great idea, but it's something that needs to be discussed in a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers plugin Related to Roblox Studio Plugin pr welcome We would support a contribution for this change
Projects
None yet
Development

No branches or pull requests

3 participants