Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics do not cleared for ignored files #77

Closed
ArchLand64 opened this issue Jul 15, 2022 · 4 comments
Closed

Diagnostics do not cleared for ignored files #77

ArchLand64 opened this issue Jul 15, 2022 · 4 comments
Labels
blocked/external Blocked on external factor bug Something isn't working

Comments

@ArchLand64
Copy link

I would like Luau-LSP to copy Roblox Studio's "Type Inference Modes" behavior documented here:
https://luau-lang.org/typecheck#type-inference-modes

This makes it easier to use other people's code that also uses these annotations without finding and changing ignore globs in vscode. I think this feature should be an optional setting in vscode to respect type inference modes annotation.

@JohnnyMorganz
Copy link
Owner

This should already be working.

Can you give an example of where this doesn't work?

@ArchLand64
Copy link
Author

Whenever I open any script in VSCode, lua-lsp will show type errors regardless of the annotation or lack of annotation at the top my script. An example of where this happens is ProfileService. I can not hide or disable type checking for ProfileService with any annotation or luau-lsp's ignore globs. Roblox Studio does not show any errors for it either.

I think there is another bug related to this which is persistent type errors in the problems tab after I close the script's tab in VSCode. After I close ProfileService.lua, I expect diagnostics to go away after I close a script unless I have diagnostics for the whole workspace enabled.

@JohnnyMorganz
Copy link
Owner

Using the type inference mode comments does work for me when I open ProfileService.

I can confirm that ignore globs still don't work though - I will look into this more

@JohnnyMorganz JohnnyMorganz changed the title Copy Roblox Studio's --!strict behavior Diagnostics do not cleared for ignored files Jul 24, 2022
@JohnnyMorganz JohnnyMorganz added the blocked/external Blocked on external factor label Jul 24, 2022
@JohnnyMorganz
Copy link
Owner

@JohnnyMorganz JohnnyMorganz added the bug Something isn't working label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/external Blocked on external factor bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants