Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staged payment payouts is broken #3996

Open
arrenv opened this issue Dec 20, 2024 · 3 comments
Open

Staged payment payouts is broken #3996

arrenv opened this issue Dec 20, 2024 · 3 comments
Labels
bug Something isn't working priority

Comments

@arrenv
Copy link
Member

arrenv commented Dec 20, 2024

NOTE: I have marked this as a priority as it seems to have concerned a user quite a bit with a fear or stolen funds, it seems to be a regression, and it continues to be possible to release the payment.

Steps to reproduce

Visible in production - https://app.colony.io/novatera?tx=0x945c8443c76082fa031d148f16f402066b9902bf865fd588f29479f3808248ca

  1. Create a Staged payment with multiple milestones.
  2. Complete the full payment process.
  3. Get to the Payment step.
  4. Release the milestone payments.
  5. Note: The milestones being released, the status of milestone payment rows, the ability to keep making payments.

Expected behaviour

  • You should see the milestones paid out shown accurately in the action timeline.
  • You should not be able to continue to create payments if the payment has already been made.
  • The status of the milestone payments should be updated accurately.
  • The Staged payment should be updated to a fully completed state if all milestones have been paid out.

Actual behaviour

  • Multiple payments for the one milestone was able to be executed.
  • Information of what milestone was released is displayed.
  • You are able to continue to create payments, but nothing is paid out.
  • The status of milestones are not updating.

Milestone labels
image

Transactions made:
image

Continual payments
image

Milestone payment status not updating
image

@arrenv arrenv added bug Something isn't working priority labels Dec 20, 2024
@olgapod
Copy link
Contributor

olgapod commented Dec 20, 2024

Hey @arrenv! We have this issue #3899 and fix #3931

@arrenv
Copy link
Member Author

arrenv commented Dec 20, 2024

Oh great, thank you for letting me know @olgapod! I will take a look.

In the meantime, from what you have seen, does it cover all things that I have raised as well?

@olgapod
Copy link
Contributor

olgapod commented Dec 20, 2024

@arrenv I've just checked. Is everything ok?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority
Projects
None yet
Development

No branches or pull requests

2 participants