Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoMapper obsolete functions #14

Closed
rfcdejong opened this issue Feb 23, 2016 · 3 comments
Closed

AutoMapper obsolete functions #14

rfcdejong opened this issue Feb 23, 2016 · 3 comments

Comments

@rfcdejong
Copy link

Currently the EfGenericDtoBase class is using obsolete functions of AutoMapper.

This has changed as of AutoMapper 4.2
https://lostechies.com/jimmybogard/2016/01/21/removing-the-static-api-from-automapper/

And they will be removed in AutoMapper 5.0

@JonPSmith
Copy link
Owner

Hi rfcdejong,

Thanks for pointing that out, as I haven't been keeping up with AutoMapper changes. I think the move away from a static Mapper is great, as static class make Unit Testing really difficult.

The main problem I see is I hide all the AutoMapper mapping setup deep inside GenericServices, as it makes it easier for developers. I really like the idea of using dependency injection to set up all the mapping. However I haven't used it in GenericServices before, so it would be a big breaking change for people. I need to study the best way to do this.

Have you any experience or suggestions of how I might go about changing over?

@rfcdejong
Copy link
Author

I'm sad to say I don't have any experience or suggestion for this just yet and I only investigated your GenericServices this week.

@JonPSmith
Copy link
Owner

I have updated GenericServices (see release V1.0.9) to use AutoMapper's now preferred way of setting up mapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants