Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to contribute this back to the SDK? #2

Open
joshpetit opened this issue Oct 20, 2023 · 1 comment
Open

Any plans to contribute this back to the SDK? #2

joshpetit opened this issue Oct 20, 2023 · 1 comment

Comments

@joshpetit
Copy link

I'm curious if you think this is something they would want to merge, since there is no way to cancel requests as of now.

@JonathanPeterCole
Copy link
Owner

No immediate plans but I'll create a PR if there's interest. There is some more work required before this would be possible though as I haven't looked into adding cancellation to the cronet_http, cupertino_http, or java_http plugins yet. There would also need to be some consideration around where the CancellationToken class should go. Currently it's part of a separate package so it can be used for other async tasks, but official Dart packages only depend on other official packages.

You may be interested in following dart-lang#424 where there's some discussion on the possible approaches for adding cancellation to the original package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants