When building pintool: error: missing binary operator before token "("

[moyix]

When building the PinTool on Ubuntu 18.04 and Pin 3.15-98253-gb56e429b1, I get:

[ 80%] Building CXX object src/tracer/pin/CMakeFiles/pintool.dir/api.cpp.o
In file included from /usr/include/x86_64-linux-gnu/c++/7/bits/c++config.h:533:0,
                 from /usr/include/c++/7/bits/stl_algobase.h:59,
                 from /usr/include/c++/7/bits/stl_tree.h:63,
                 from /usr/include/c++/7/set:60,
                 from /home/moyix/pintmp/pin-3.15-98253-gb56e429b1-gcc-linux/source/tools/Triton/src/libtriton/includes/triton/architecture.hpp:11,
                 from /home/moyix/pintmp/pin-3.15-98253-gb56e429b1-gcc-linux/source/tools/Triton/src/libtriton/includes/triton/api.hpp:11,
                 from /home/moyix/pintmp/pin-3.15-98253-gb56e429b1-gcc-linux/source/tools/Triton/src/tracer/pin/api.cpp:8:
/usr/include/x86_64-linux-gnu/c++/7/bits/os_defines.h:44:19: error: missing binary operator before token "("
 #if __GLIBC_PREREQ(2,15) && defined(_GNU_SOURCE)
                   ^

From other issues I found it seems this might be due to glibc being too new and Pin monkeying with the standard headers somehow.

As a side question, is there a particular distribution/version and kernel version that Triton is known to work well with?

Note: I also had to add a couple other include paths to src/tracer/pin/CMakeLists.txt to get it to find XED and the Pin CRT:

diff --git a/src/tracer/pin/CMakeLists.txt b/src/tracer/pin/CMakeLists.txt
index 5209af3a..6dc7202a 100644
--- a/src/tracer/pin/CMakeLists.txt
+++ b/src/tracer/pin/CMakeLists.txt
@@ -59,16 +59,19 @@ endif()
 # Includes directories (Pin)
 if(${ARCHITECTURE} STREQUAL "i386")
     include_directories("${PIN_ROOT}/extras/xed-ia32/include")
+    include_directories("${PIN_ROOT}/extras/xed-ia32/include/xed")
 endif()
 
 if(${ARCHITECTURE} STREQUAL "amd64")
     include_directories("${PIN_ROOT}/extras/xed-intel64/include")
+    include_directories("${PIN_ROOT}/extras/xed-intel64/include/xed")
 endif()
 
 include_directories("${PIN_ROOT}/source/include/pin")
 include_directories("${PIN_ROOT}/source/include/pin/gen")
 include_directories("${PIN_ROOT}/extras/components/include")
 include_directories("${PIN_ROOT}/source/tools/InstLib")
+include_directories("${PIN_ROOT}/extras/crt/include")
 
 
 # Libs directories (Pin)

[XVilka]

You could try Docker https://github.com/JonathanSalwan/Triton/blob/master/Dockerfile

[JonathanSalwan]

Hey Brendan,

The only difference between Pin 2.14 and pin 3 is their CRT. As far as I tested, using their CRT implies several issues when linking with other libs (e.g: libpython, libtriton). So, if you want to the use the Pin tracer and the libTriton, I recommend to use Pin 2.14 (which is maintained only for Python 2.7).

The compile:

$ mkdir build ; cd build
$ cmake -DPINTOOL=on -DPYTHON36=off ..
$ ./triton ../src/examples/pin/ir.py /usr/bin/id

[JonathanSalwan]

I've also made a QBDI+Triton tracer.

[moyix]

Nice, this works quite well! :) Thanks!