Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch grafana index is not easily configurable #25

Closed
sonnysideup opened this issue Oct 30, 2014 · 3 comments · Fixed by #30
Closed

Elasticsearch grafana index is not easily configurable #25

sonnysideup opened this issue Oct 30, 2014 · 3 comments · Fixed by #30

Comments

@sonnysideup
Copy link
Contributor

https://github.com/JonathanTron/chef-grafana/blob/master/attributes/default.rb#L64

Since node['grafana']['datasources']['elasticsearch']['index'] is a derived value (i.e. string interpolated using another node value), it will not change whenever someone changes node['grafana']['grafana_index'].

@JonathanTron
Copy link
Contributor

I know, this is a pet peave I have with attributes, what do you propose to fix it?

There's a lot of alternatives, but each have it's own set of problems.

I'm usually keen to create wrapper cookbooks and chef-grafana is meant to be used wrapped into one when default configuration is not enough. Then replacing the whole default['grafana']['datasources'] makes more sense.

@sonnysideup
Copy link
Contributor Author

You're right, there are a number of alternatives. Let me fork and toy with it a bit to see if can come up with something that works well.

@lock
Copy link

lock bot commented Jul 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants