Cleanup

[ghost]

I been working on cleaning some stuff up in the cookbook and adding some more tests.

One notable change is, I changed the default location from /opt /srv/apps based on FHS.

Just about everything else was test related or rubocop related.

[ghost]

I should also note I changed the default installation method to file. Using git master is probably a bit risky, a single commit could break things. I switched it over to use the file install_type by default so the cookbook can follow stable releases. Git is always there if someone actually needs it.

[JonathanTron]

Thanks for your hard work.

[ghost]

Thanks for the merge! 🍻

[arifcse019]

@gregf Can you please explain a little bit how installation path /opt violates FHS? I checked the relevant section in the document but could not find the answer

[ghost]

@arifcse019 My thoughts were based on what the definition of /srv says, which can be found here

Which basically says /srv is for site specific data including www, rsync, ftp, and csv. Since we are serving www data I felt /srv is where it belonged.

opt talks about configuration files and static binary packages. I don't see anything that mentions the type of files we're are storing here.

I'm open to other thoughts on the matter though, so let me know if I'm missing something.

[arifcse019]

Thanks and Disclaimer: I am not a pro in Unix system administration. Just trying to better understand why things are done in certain way.

So under FHS definition. /srv is for data but not the applications that serve those data about the sites hosted on the machine. What do you think?

[ghost]

@arifcse019 Sounds good

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.