fix role specification for elasticsearch and graphite

[jwmarshall]

This change fixes the ability to dynamically configure the remote end points for graphite and elasticsearch. I could not figure out how the original method was supposed to work given that the es_server and graphite_server had default variables defined in attributes/default.rb

[JonathanTron]

Thanks for the pull-request.
What is expected is that once you want to use the roles you set:

override['grafana']['es_server'] = nil
override['grafana']['graphite_server'] = nil

and either use the defaults node['grafana']['es_role']/node['grafana']['graphite_role'] or change them to match yours.

I think your change is fine and will apply it with a warning in the README that it will now search for the es_role/graphite_role by default even if you set the es_server/graphite_server and will replace the defaults.

[jwmarshall]

Jonathan, that makes a little more sense as setting the default to nil did not work for me. I guess using override or normal even would have worked. However the override of each server to nil feels very strange when you're reading the environment/role attributes. I think the update you've merge makes the most sense, but I'm probably biased to that as I wrote the pull request.

Never-the-less thank you for a great cookbook and merging my updates. 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.