SqlHydra.Cli missing SQL Server timestamp data type mapping

[tommi1hirvonen]

SQL Server includes the timestamp data type, which is essentially a synonym for rowversion. Mapping for this data type is missing from SqlServerDataTypes.fs, which means columns with data type timestamp are currently excluded from generated SqlHydra types and readers. rowversion is included in the data type mappings, and thus I believe timestamp should be implemented too.

[JordanMarr]

Which data type does it map to?
DateTime? DateTimeOffset?

[tommi1hirvonen]

I think it should actually map to byte[], since it's the same as rowversion. I manually added the missing timestamp column to my generated SqlHydra type and reader as byte[], and that seemed to work correctly. Also, according to Microsoft's documentation the correct ClrType for timestamp is Byte[].

This could potentially be as simple as just copying the rowversion mapping like this:

SqlServerdatatypes.ds

let supportedTypeMappings =
    [
        // ...
        "ROWVERSION", "byte[]", DbType.Binary, Some (nameof SqlDbType.Binary), nameof r.GetFieldValue
        // Added timestamp data type mapping
        "TIMESTAMP", "byte[]", DbType.Binary, Some (nameof SqlDbType.Binary), nameof r.GetFieldValue
        // ...
    ]

And yes, timestamp in SQL Server is notorious for being confusing and badly named. 😄

[JordanMarr]

Added to v2.5.3.