Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The documentation for CommandAPI.onDisable() is not very clear #330

Closed
JorelAli opened this issue Aug 24, 2022 · 2 comments
Closed

The documentation for CommandAPI.onDisable() is not very clear #330

JorelAli opened this issue Aug 24, 2022 · 2 comments
Labels
documentation Documentation improvement implemented for next release This has been implemented in the current dev build for the next public release

Comments

@JorelAli
Copy link
Owner

Documentation URL

https://commandapi.jorel.dev/8.5.1/shading.html#disabling

What the documentation currently says

The onDisable() method disables the CommandAPI gracefully. This should be placed in your plugin's onDisable() method. This doesn't unregister commands, so commands may persist during reloads - this can be mitigated using the CommandAPI.unregister() method.

Proposed fix

A code block with:

CommandAPI.onDisable();

Possibly an example as well!
@JorelAli JorelAli added the documentation Documentation improvement label Aug 24, 2022
@JorelAli
Copy link
Owner Author

Implemented in 242c26b for 8.6.0.

@JorelAli JorelAli added the implemented for next release This has been implemented in the current dev build for the next public release label Sep 24, 2022
@JorelAli
Copy link
Owner Author

JorelAli commented Dec 4, 2022

Implemented in release 8.6.0.

@JorelAli JorelAli closed this as completed Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Documentation improvement implemented for next release This has been implemented in the current dev build for the next public release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JorelAli