Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test environment #4

Open
Jorge-Lopes opened this issue Jan 11, 2024 · 0 comments
Open

Test environment #4

Jorge-Lopes opened this issue Jan 11, 2024 · 0 comments

Comments

@Jorge-Lopes
Copy link
Owner

Jorge-Lopes commented Jan 11, 2024

Unit tests

Context:

Considering that we intend to update the inter-protocol pkg source code to extend the data being published to the storage node for increased visibility of the vaults liquidation, auction and post auction distribution.
We plan to increase the test coverage in this regard to assure that our updates are behaving accordingly.

A more detailed description of the assignment and solution proposed can be found here

Open Questions:

  1. Should we extend an existing test file, (e.g. inter-protocol/test/vaultFactory/test-vaultLiquidation.js), or create a new one?
  2. In case of creating a new file, would it be beneficial for us to either build a file to export some support functions or extend an existing one, (e.g. vaultFactoryUtils.js), to avoid duplicating code.
    For example:
  • setupBasics
  • setupServices
  • setClockAndAdvanceNTimes
  • startAuctionClock
  • bid
  • ...

Current approach (WiP)

As an experiment to explore the liquidation visibility, without risking creating a conflict with a future merge, we create a new directory called liquidationVisibility that contain some of the tests created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant