New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure protocol compatibility with third party integrations #385

Closed

JoseExposito opened this issue Nov 10, 2020 · 0 comments

Assignees

Labels

enhancement Priority-High

Milestone

Owner

JoseExposito commented Nov 10, 2020

In the current release (v2.0.2) Touchégg is the only client using the daemon.

However, if this integration with Gala gets merged (elementary/gala#958) the protocol needs to be improved to avoid breaking changes.

Changes required:

Make sure the enums doesn't change. Add a fixed number to each enum value:
https://github.com/JoseExposito/touchegg/blob/master/src/gesture/gesture-type.h
https://github.com/JoseExposito/touchegg/blob/master/src/gesture/gesture-direction.h
https://github.com/JoseExposito/touchegg/blob/master/src/daemon/gesture-event.h
Send the event size in a uint32_t before the GestureEvent so changes in the GestureEvent struct don't break Gala
Add a warning to ensure the order in the GestureEvent fields don't change

The text was updated successfully, but these errors were encountered:

JoseExposito added enhancement Priority-High labels

JoseExposito added this to the 2.0.3 milestone

JoseExposito self-assigned this

JoseExposito closed this as completed in

881bbcd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment