Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCS1032: Include handling for SimpleMemberAccess #1064

Merged
merged 3 commits into from
Apr 9, 2023

Conversation

jamesHargreaves12
Copy link
Contributor

Currently, RCS1032 won't be suggested for SimpleMemberAccesses e.g.

(X).Y

This PR adds support for this.

@jamesHargreaves12 jamesHargreaves12 changed the title Include handling for SimpleMemberAccess RCS1032: Include handling for SimpleMemberAccess Apr 3, 2023
Copy link
Collaborator

@josefpihrt josefpihrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesHargreaves12 LGTM, just please resolve changelog.

UPDATE: I did it.

@josefpihrt josefpihrt merged commit 8ef690f into dotnet:main Apr 9, 2023
Haarmees pushed a commit to Haarmees/Roslynator that referenced this pull request Oct 30, 2023
Co-authored-by: Josef Pihrt <josef.pihrt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants