Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RCS1216 #1094

Merged
merged 9 commits into from
Jun 22, 2023
Merged

Fix RCS1216 #1094

merged 9 commits into from
Jun 22, 2023

Conversation

jamesHargreaves12
Copy link
Contributor

Currently, if an unsafe local block is located inside a for statement then one of the asserts will fail https://github.com/JosefPihrt/Roslynator/blob/1d035ba7b32fafd9057e3c02f3a903a1493ae212/src/Analyzers/CSharp/Analysis/UnnecessaryUnsafeContextAnalyzer.cs#L248

For example

    class C
    {
        unsafe void M()
        {
            for(int y = 0; y < 10; y ++){
                unsafe void M2() {
                    var x = 1;
                }
            }
        }
    }

To fix this and make the code easier to grok I refactored the 3 distinct methods of walking up the syntax tree checking for unsafe modifiers into a single loop. I also Added a new test suite for the analyzer/code fix of RCS1216 as one currently does not exist.

Copy link
Collaborator

@josefpihrt josefpihrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to simplify the code even more, the method

private static void AnalyzeMemberDeclaration(SyntaxNodeAnalysisContext context)

can include all type declarations and member declarations. Virtually all cases except UnsafeStatement and LocalFunctionStatement.

@josefpihrt josefpihrt merged commit ab44361 into dotnet:main Jun 22, 2023
Haarmees pushed a commit to Haarmees/Roslynator that referenced this pull request Oct 30, 2023
Co-authored-by: Josef Pihrt <josef.pihrt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants