Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Add type guards for flow nodes #248

Open
3 tasks done
RebeccaStevens opened this issue Jul 24, 2023 · 5 comments
Open
3 tasks done

🚀 Feature: Add type guards for flow nodes #248

RebeccaStevens opened this issue Jul 24, 2023 · 5 comments
Assignees
@RebeccaStevens
Labels
status: in discussion Not yet ready for implementation or a pull request type: feature New enhancement or request 🚀

Comments

@RebeccaStevens
Copy link
Collaborator

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

The flow nodes are:

  • FlowNode
  • FlowStart
  • FlowLabel
  • FlowAssignment
  • FlowCondition
  • FlowSwitchClause
  • FlowArrayMutation
  • FlowCall
  • FlowReduceLabel

Flow nodes are NOT Nodes (they don't have a kind).

Additional Info

No response
@RebeccaStevens RebeccaStevens added the type: feature New enhancement or request 🚀 label Jul 24, 2023
@RebeccaStevens RebeccaStevens self-assigned this Jul 24, 2023
@RebeccaStevens RebeccaStevens mentioned this issue Jul 24, 2023
Closed
3 tasks
@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Jul 25, 2023 •
edited
Loading

This seems reasonable to me - but do you have any references that can be linked here, e.g. good PRs or functions inside TypeScript? I'm honestly very unfamiliar with how TypeScript does flow nodes.

@RebeccaStevens
Copy link
Collaborator Author

No, I'm not very familiar with them either.

@JoshuaKGoldberg
Copy link
Owner

Is there somewhere you're hoping to use these?

@RebeccaStevens
Copy link
Collaborator Author

I was planning on using them for a new option of an eslint rule I was working on, but it turned out these weren't what I was looking for. (It turned out I could do it much more simply)

Thought I'd still open this issue though incase someone else needs them in future.

@JoshuaKGoldberg JoshuaKGoldberg added the status: in discussion Not yet ready for implementation or a pull request label Aug 5, 2023
@JoshuaKGoldberg
Copy link
Owner

👍 marking as status: in discussion pending posting a use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RebeccaStevens RebeccaStevens

Labels
status: in discussion Not yet ready for implementation or a pull request type: feature New enhancement or request 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add flow node type guards JoshuaKGoldberg/ts-api-utils
2 participants
@JoshuaKGoldberg @RebeccaStevens