Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request only required amount for approval #5

Open
kdembler opened this issue Aug 15, 2024 · 0 comments
Open

Request only required amount for approval #5

kdembler opened this issue Aug 15, 2024 · 0 comments

Comments

@kdembler
Copy link
Member

Before you can bridge from Base to Joystream, you first need to do ERC20 approval for the ArgoBridgeV1 contract to move tokens on your behalf. Currently, we ask the user to approve the max possible amount of tokens, which is not the best practice. Instead, the approval should be only for the amount that the user actually want to transfer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant