Cleanup forum parameters

[bedeho]

The parameters defined for the forum pallet are not all used

parameter_types! {
    pub const MaxCategoryDepth: u64 = 6;
    pub const MaxSubcategories: u64 = 20;
    pub const MaxThreadsInCategory: u64 = 20;
    pub const MaxPostsInThread: u64 = 20;
    pub const MaxModeratorsForCategory: u64 = 20;
    pub const MaxCategories: u64 = 20;
    pub const MaxPollAlternativesNumber: u64 = 20;
    pub const ThreadDeposit: u64 = 30;
    pub const PostDeposit: u64 = 10;
    pub const ForumModuleId: ModuleId = ModuleId(*b"mo:forum"); // module : forum
    pub const PostLifeTime: BlockNumber = 3600;
}

I can verify that at lest MaxPostsInThread, which would be a very costly constraint, is not actually used. I suggest the list is reviewed and cleaned up.

┆Issue is synchronized with this Asana task by Unito

[bedeho]

Covered by #2914.