Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SCRIBBLE_Z from macros? #53

Closed
JujuAdams opened this issue Apr 29, 2020 · 2 comments
Closed

Remove SCRIBBLE_Z from macros? #53

JujuAdams opened this issue Apr 29, 2020 · 2 comments
Labels
opinions pls ❓ Feedback needed

Comments

@JujuAdams
Copy link
Owner

JujuAdams commented Apr 29, 2020

SCRIBBLE_Z currently passes in a uniform into the default Scribble shader to control the eventual vertex z-position of text. We do this because Scribble hijacks the z-coordinate of the vertex position to communicate other data (specifically the character/line index).

Passing around SCRIBBLE_Z as a uniform has a non-zero cost for rendering text and it adds clutter to the library in general. I feel like if someone was using GM for 3D they'd understand enough about shaders (the graphics pipeline in general) to make this edit themselves.

@JujuAdams JujuAdams added the opinions pls ❓ Feedback needed label Apr 29, 2020
@DragoniteSpam
Copy link

I've never used the macro, even in 3D. I feel like if I were to draw a scribble in 3D space I'd probably slap it on a 2D surface first or something.

@JujuAdams
Copy link
Owner Author

I'll take it out for 5.5.0 then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opinions pls ❓ Feedback needed
Projects
None yet
Development

No branches or pull requests

2 participants