Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_events_char_array sometimes not initialized in scribble_cache #90

Closed
DragoniteSpam opened this issue Jul 7, 2020 · 4 comments
Closed
Labels
bug 😅 Juju did a bad thing

Comments

@DragoniteSpam
Copy link

I'm not 100% sure where this originates from, but sometimes if I create a scribble with a unique occurrence name more than once scribble_cache will fail thanks to _events_char_array not being given a value. I can't pin down which line that would assign it a value is being skipped, although declaring

var _events_char_array = [];

at the top of the script takes care of it.

Also, spell check tells me it's spelled "occurrence" instead of "occurance" but I don't know if I can be bothered to fix that in all of my code so.

@JujuAdams
Copy link
Owner

Thanks for the bug report

At line 58 in scribble_cache() you'll find

var _scribble_array = global.__scribble_global_cache_map[? _cache_string];

Underneath this line, please add:

_events_char_array = _scribble_array[SCRIBBLE.EVENT_CHAR_ARRAY];

Could you confirm whether this prevents the crash from occurring?

@JujuAdams JujuAdams added the bug 😅 Juju did a bad thing label Jul 7, 2020
@DragoniteSpam
Copy link
Author

That did it. Thank!

@JujuAdams
Copy link
Owner

Gonna reopen this so I remember to fix it in the repo 👀

@JujuAdams
Copy link
Owner

Hokay, fixed for v6.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 😅 Juju did a bad thing
Projects
None yet
Development

No branches or pull requests

2 participants