-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface for LowRankModels.jl #44
Comments
That would be wonderful!! Regarding competing algorithms, let me continue the discussion here |
Just a warning. If you are implementing transformers rather than supervised models (e.g. PCA) then there is no |
Ok thanks, I will try and might again need some guidance in a WIP PR. I thought I'd mimic some of the stuff that you looked at for MultivariateStats |
I only implemented RidgeRegressor from there. |
The transformers we have live in |
(I know there's still #35 waiting to be done but the models for which there already is a ScikitLearn.jl interface are somewhat easier to write interfaces for which, hopefully, will make me confident enough to help out on more complex stuff later).
LowRankModels.jl implements quite a lot of interesting stuff:
[1] how do you envisage competing algorithms for the same task? E.g. if two packages do KMeans and implement MLJBase? Or, in fact, if two packages implement PCA like here and
MultivariateStats
?I'm happy to try implement an interface for these.
The text was updated successfully, but these errors were encountered: