Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export jacobian #87

Open
dlfivefifty opened this issue Jul 6, 2021 · 3 comments
Open

Don't export jacobian #87

dlfivefifty opened this issue Jul 6, 2021 · 3 comments
Labels

Comments

@dlfivefifty
Copy link
Member

Conflicts with ForwardDiff.jacobian

@daanhb
Copy link
Member

daanhb commented Jul 6, 2021

Yes good point. I've been thinking it might be better to put all of the maps-associated functionality in a separate submodule, and eventually in a separate package.

@dlfivefifty
Copy link
Member Author

I would support that since it's orthogonal to domains

@daanhb
Copy link
Member

daanhb commented Jul 6, 2021

Indeed. We identified a number of overlapping packages some time ago, but the majority of them don't support rectangular or other non-invertible maps so I went ahead and implemented what I needed to support e.g. parametric domains. But that should not be exposed when just using domains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants