Register this package?

[daanhb]

@dlfivefifty @MikaelSlevinsky any opinions on whether or not to proceed like this?

[daanhb]

The code in this package is like that in FastTransforms.jl except that it no longer specializes DSP.conv, in order to reduce the dependencies.
FastTransforms.jl could just use GenericFFT and it would simply still have to define:

import DSP: conv
conv(u::AbstractArray{T, N}, v::AbstractArray{T, N}) where {T<:AbstractFloat, N} =
    GenericFFT._conv!(deepcopy(u), deepcopy(v))
conv(u::AbstractArray{T, N}, v::AbstractArray{Complex{T}, N}) where {T<:AbstractFloat, N} =
    GenericFFT._conv!(complex(deepcopy(u)), deepcopy(v))
conv(u::AbstractArray{Complex{T}, N}, v::AbstractArray{T, N}) where {T<:AbstractFloat, N} =
    GenericFFT._conv!(deepcopy(u), complex(deepcopy(v)))
conv(u::AbstractArray{Complex{T}, N}, v::AbstractArray{Complex{T}, N}) where {T<:AbstractFloat, N} =
    GenericFFT._conv!(deepcopy(u), deepcopy(v))

[dlfivefifty]

I’ll defer to @MikaelSlevinsky who wrote the original code… but I’m sure it’s a good idea

[MikaelSlevinsky]

Hi @daanhb, thanks for taking charge of this! I would say that registration is good idea.

As for conv, can't remember the last time I used it, but looking at dspbase.jl, maybe a PR there that changes some of the type restrictions on conv would solve a bunch of issues.

For example, the 3-arg (matrix) conv has no type restriction. Since it uses fft and ifft, if GenericFFT were loaded then I think it would just work beyond FFTWNumbers.

This would mean importing DSP in FastTransforms may also be removable.

[daanhb]

@JuliaRegistrator register

[JuliaRegistrator]

Registration pull request created: JuliaRegistries/General/64580

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.0 -m "<description of version>" 93a246006dff9c1f0b444183830bd6a8fc72fb2f
git push origin v0.1.0