Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayViews - "T not defined" - Julia 0.4 #15

Closed
rennis250 opened this issue Oct 23, 2014 · 7 comments
Closed

ArrayViews - "T not defined" - Julia 0.4 #15

rennis250 opened this issue Oct 23, 2014 · 7 comments

Comments

@rennis250
Copy link

Hey there,

When loading ArrayViews on Julia 0.4.0-dev+1719, I get the following error:

ERROR: T not defined
 in include at ./boot.jl:242
 in include_from_node1 at ./loading.jl:128
 in reload_path at ./loading.jl:152
 in _require at ./loading.jl:67
 in require at ./loading.jl:54
 in require at /Users/rje/julia04/usr/lib/julia/sys.dylib
 in include at ./boot.jl:242
 in include_from_node1 at ./loading.jl:128
 in reload_path at ./loading.jl:152
 in _require at ./loading.jl:67
 in require at ./loading.jl:54
 in require at /Users/rje/julia04/usr/lib/julia/sys.dylib
 in include at ./boot.jl:242
 in include_from_node1 at ./loading.jl:128
 in reload_path at ./loading.jl:152
 in _require at ./loading.jl:67
 in require at ./loading.jl:52
 in require at /Users/rje/julia04/usr/lib/julia/sys.dylib
 in include at ./boot.jl:242
 in include_from_node1 at ./loading.jl:128
 in try_include at ./client.jl:172
 in load_juliarc at ./client.jl:335
 in _start at ./client.jl:390
 in _start at /Users/rje/julia04/usr/lib/julia/sys.dylib
while loading /Users/rje/.julia/v0.4/ArrayViews/src/ArrayViews.jl, in expression starting on line 44
while loading /Users/rje/.julia/v0.4/Distributions/src/Distributions.jl, in expression starting on line 3
while loading /Users/rje/.julia/v0.4/LsqFit/src/LsqFit.jl, in expression starting on line 9
while loading /Users/rje/.juliarc.jl, in expression starting on line 1

I have to run off, but I will try to see if I can fix this a bit later today.

Thanks and best,
Rob

@ivarne
Copy link

ivarne commented Oct 23, 2014

See https://groups.google.com/forum/#!searchin/julia-dev/%22T$20not$20defined%22/julia-dev/NogEb8ndFxE/05eOLL2jaicJ

which references JuliaLang/julia#8505

The problem comes from the use of T two times in the type signature.

immutable ContiguousView{T,N,Arr<:Array{T}} <: ArrayView{T,N,N}
    arr::Arr
    offset::Int
    len::Int
    shp::NTuple{N,Int}
end

@rennis250
Copy link
Author

I see, but then I am a bit confused. JuliaLang/julia#8505 is reported as fixed, but the error still occurs. This hamstrings a number of dependent packages, including Distributions, which other packages depend on. Is it an acceptable design choice to rewrite the ArrayView type, so that it can somehow infer the type, rather than being told the type?

cc: @lindahua, @JeffBezanson, @timholy

Best,
Rob

@ivarne
Copy link

ivarne commented Oct 25, 2014

Apparently the previous behaviour will be restored with #17.

@tkelman
Copy link
Contributor

tkelman commented Oct 26, 2014

Unfortunately Dahua has not had time to do any Julia work, he has no Github activity for over a month. Stefan and I emailed him and asked whether we can move some of his more important packages to JuliaLang so bugs can be fixed. Still waiting on resolution there. If it does not go anywhere then we can switch Metadata to point to a fork.

@lindahua
Copy link
Contributor

Sorry for the delay. I just got my grant proposal submitted. 

I can resume my Julia contribution to some extent. But for long-term maintenance, I think I should transmit the ownership of this package to JuliaLang.

Stefan, can you grant me temporary permission to finish this?

Thanks
Dahua

On 27 October, 2014 at 5:22:21 am, Tony Kelman (notifications@github.com) wrote:

Unfortunately Dahua has not had time to do any Julia work, he has no Github activity for over a month. Stefan and I emailed him and asked whether we can move some of his more important packages to JuliaLang so bugs can be fixed. Still waiting on resolution there. If it does not go anywhere then we can switch Metadata to point to a fork.


Reply to this email directly or view it on GitHub.

@lindahua
Copy link
Contributor

Fixed by 3346c76. Checkout the latest 0.4.7, and it should work now.

@timholy
Copy link
Member

timholy commented Oct 28, 2014

Great, and welcome back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants