Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Square type parameter #107

Open
mzgubic opened this issue Jun 21, 2022 · 0 comments · May be fixed by #114
Open

Add a Square type parameter #107

mzgubic opened this issue Jun 21, 2022 · 0 comments · May be fixed by #114
Labels
enhancement New feature or request

Comments

@mzgubic
Copy link
Collaborator

mzgubic commented Jun 21, 2022

As discussed in #94, this package does not publicly distinguish between square and non-square BlockDiagonal matrices, and @nickrobinson251 convinced me that is the right thing to do.

However, it might be useful to distinguish between square and non-square BlockDiagonals internally for the following reasons:

@mzgubic mzgubic added the enhancement New feature or request label Jun 21, 2022
@mzgubic mzgubic linked a pull request Jul 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant