Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't specialize IndexStyle for IndexCartesian #256

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jul 10, 2023

These methods aren't necessary, as the fallback method for AbstractArrays returns IndexCartesian.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #256 (276845a) into master (cae6f8a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   93.53%   93.57%   +0.03%     
==========================================
  Files          13       13              
  Lines        2368     2364       -4     
==========================================
- Hits         2215     2212       -3     
+ Misses        153      152       -1     
Impacted Files Coverage Δ
src/lazyconcat.jl 95.84% <ø> (-0.02%) ⬇️
src/lazyoperations.jl 96.69% <100.00%> (+0.34%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dlfivefifty dlfivefifty merged commit ce39026 into JuliaArrays:master Jul 11, 2023
14 checks passed
@jishnub jishnub deleted the indexstyle branch July 11, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants