-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare StaticArrays functions in StaticArraysCore #11
Comments
Sure, we can declare functions in StaticArraysCore.jl. We already have |
Great! Looks like we need |
Yes, exactly, one PR like this one: #5 and one like this: JuliaArrays/StaticArrays.jl#1084 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Avoiding a dependency on all of StaticArrays requires being able to define all needed methods using only StaticArraysCore. For example, in this Accessors PR we need to be able to this code to work:
But
deleteat
andinsert
are declared (and defined) in StaticArrays itself, so these two lines of code currently require all of StaticArrays before the compiler will even accept them.This seems to defeat the purpose of having a separation like this in the first place. This makes me wonder, could there be a minimal set of functions in StaticArrays that you'd consider useful for interfacing from "StaticArrays-optional" libraries like Accessors?
Could
deleteat
andinsert
, and whatever other functions you think might play a similar role, be declared in StaticArraysCore, and then implemented in StaticArray?The text was updated successfully, but these errors were encountered: