Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on Detected WEAK-ENCRYPTION #660

Closed
zyue110026 opened this issue Sep 20, 2023 · 1 comment
Closed

Feedback on Detected WEAK-ENCRYPTION #660

zyue110026 opened this issue Sep 20, 2023 · 1 comment

Comments

@zyue110026
Copy link

Greetings,

We are some security researchers who have built a scanner to detect known security weaknesses. For your repository, we have found instances of Weak Encryption in the following locations:

Location-1:

expected_content_md5 = base64encode(digest(MD_MD5, request.content))

Please give us feedback. Do you think these are valid instances on security weaknesses? Will you fix them?

@ericphanson
Copy link
Member

That is in the tests, not the source code. The corresponding source code is

"Content-MD5" => base64encode(digest(MD_MD5, request.content)),

I don't think that Content-MD5 header is for encryption but rather object integrity. The object is hashed with SHA256 as part of the the AWS v4 signature process.

So I don't think this is a security weakness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants