Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resize!(::CircularBuffer, n) is surprising #838

Open
rfourquet opened this issue Dec 13, 2022 · 0 comments
Open

resize!(::CircularBuffer, n) is surprising #838

rfourquet opened this issue Dec 13, 2022 · 0 comments
Milestone
1.0

Comments

@rfourquet
Copy link
Contributor

Following up on #548 (comment), resize! usually changes the length of collections, but not for CircularBuffer (am I missing an altenate convention in this package?). IMO it should be renamed, e.g. to sizehint!, or setcapacity! or capacity!. The introduction of resize! (#784) seems to not have yet been released, so this wouldn't be breaking.

This issue is similar to #447.
@oxinabox oxinabox added this to the 1.0 milestone Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@oxinabox @rfourquet