-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs should reflect changed indexcols and datacols behavior when filenamecol is active #245
Comments
That seems like a good change to me. |
First column in an ndsparse is the longest "stride". That's why I thought it made sense... |
The When you start with this: loadtable(one_file; indexcols = (1,2), datacols = (3,4,5)) Loading multiple files becomes: # proposed change
loadtable(many_files; indexcols = (6,1,2), datacols = (3,4,5), filenamecol = :File)
# current behavior
loadtable(many_files; indexcols = (1,2,3), datacols = (4,5,6), filenamecol = :File) I think I prefer the proposed change, but at worst the current behavior is only a slight inconvenience. |
The behavior is still unchanged, so I guess the matter is decided. I think the docs should mention this quirk! |
If I
loadtable
withfilenamecol = :source_file
this creates a new first column.Then
indexcols
anddatacols
need to be shifted by one index, which is a bit impractical. So, I suggest that thefilenamecol
should be the appended as the last column of the resulting table.The text was updated successfully, but these errors were encountered: