Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PooledVectors for isbitstypes of small size? #982

Open
sairus7 opened this issue Feb 18, 2022 · 0 comments · May be fixed by #983
Open

PooledVectors for isbitstypes of small size? #982

sairus7 opened this issue Feb 18, 2022 · 0 comments · May be fixed by #983
Labels
performance

Comments

@sairus7
Copy link

sairus7 commented Feb 18, 2022 •
edited
Loading 

data = """a	b	c	d
A	BB	CCC	DDDD
A	BB	CCC	DDDD
""" |> IOBuffer
df = CSV.File(data; header = 1) |> DataFrame

df[!, :a] # 2-element PooledVector{String1, UInt32, Vector{UInt32}}
df[!, :b] # 2-element PooledVector{String3, UInt32, Vector{UInt32}}
df[!, :c] # 2-element PooledVector{String3, UInt32, Vector{UInt32}}
df[!, :d] # 2-element PooledVector{String7, UInt32, Vector{UInt32}}
@sairus7 sairus7 changed the title PooledVectors for isbitstypes, and some more PooledVectors for isbitstypes of small size? Feb 18, 2022
@quinnj quinnj transferred this issue from JuliaData/DataFrames.jl Feb 18, 2022
quinnj added a commit that referenced this issue Feb 19, 2022
@quinnj
Don't pool small inline string columns by default
04f066a 
Fixes #982. Since the size of `String1` and `String3` are <= the size of
the ref integer type we use for pooling (`UInt32`), let's avoid pooling
them by default. Users can still request specific columns be pooled like
always.
@quinnj quinnj linked a pull request Feb 19, 2022 that will close this issue
Open
nickrobinson251 pushed a commit that referenced this issue Oct 7, 2022
@quinnj @nickrobinson251
Don't pool small inline string columns by default
33d1d85 
Fixes #982. Since the size of `String1` and `String3` are <= the size of
the ref integer type we use for pooling (`UInt32`), let's avoid pooling
them by default. Users can still request specific columns be pooled like
always.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't pool small inline string columns by default JuliaData/CSV.jl
2 participants
@nickrobinson251 @sairus7